Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cosmosutil): add querying methods for the Auth module #19

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat(cosmosutil): add querying methods for the Auth module #19

merged 1 commit into from
Dec 29, 2023

Conversation

Zygimantass
Copy link
Contributor

No description provided.

@Zygimantass Zygimantass mentioned this pull request Dec 27, 2023
Merged
@Zygimantass Graphite App
Copy link
Contributor Author

Zygimantass commented Dec 27, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_InteractingWallet_and_a_scaffold_of_the_ChainClient branch from 5f13b65 to ccf3352 Compare December 27, 2023 12:34
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch from 72a7a84 to a2af9e8 Compare December 27, 2023 12:35
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_InteractingWallet_and_a_scaffold_of_the_ChainClient branch from ccf3352 to 8c83841 Compare December 27, 2023 12:39
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch 2 times, most recently from 49b3faa to 132811e Compare December 27, 2023 12:41
nivasan1
nivasan1 reviewed Dec 27, 2023
View reviewed changes
cosmosutil/auth.go
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
)

func (c *ChainClient) Account(ctx context.Context, address string) (sdk.AccountI, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this method in the Wallet's Account query?

nivasan1
nivasan1 reviewed Dec 27, 2023
View reviewed changes
Copy link
Contributor

@nivasan1 nivasan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions

@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_InteractingWallet_and_a_scaffold_of_the_ChainClient branch from 8c83841 to 3f371b7 Compare December 28, 2023 15:03
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch from 132811e to ca4042a Compare December 28, 2023 15:03
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

1 similar comment
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_InteractingWallet_and_a_scaffold_of_the_ChainClient branch from 3f371b7 to 072ba62 Compare December 29, 2023 11:47
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch from ca4042a to 16f3ead Compare December 29, 2023 11:48
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_InteractingWallet_and_a_scaffold_of_the_ChainClient branch from 072ba62 to cf7e20e Compare December 29, 2023 11:52
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch 2 times, most recently from 2948a71 to af150a8 Compare December 29, 2023 11:54
@Zygimantass Zygimantass force-pushed the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch from af150a8 to ecf095e Compare December 29, 2023 11:55
@Zygimantass Graphite App
Copy link
Contributor Author

Zygimantass commented Dec 29, 2023 •
edited
Loading

Merge activity

@Zygimantass Zygimantass changed the base branch from 12-27-feat_cosmosutil_add_InteractingWallet_and_a_scaffold_of_the_ChainClient to main December 29, 2023 12:04
@Zygimantass Zygimantass merged commit dd82ee2 into main Dec 29, 2023
13 checks passed
@Zygimantass Zygimantass deleted the 12-27-feat_cosmosutil_add_querying_methods_for_the_Auth_module branch January 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivasan1 nivasan1 nivasan1 left review comments

@davidterpay davidterpay Awaiting requested review from davidterpay

@aljo242 aljo242 Awaiting requested review from aljo242 aljo242 is a code owner

@Eric-Warehime Eric-Warehime Awaiting requested review from Eric-Warehime Eric-Warehime is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zygimantass @nivasan1